-
Notifications
You must be signed in to change notification settings - Fork 152
Migrate from poetry
to uv
#2785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
81e36ec
to
bae7e40
Compare
1f52d00
to
b0b3756
Compare
7cbd099
to
bf64bac
Compare
I migrated the nix derivation from poetry to uv and refactored the nix derivations at the same time. I also added uv2nix and pyproject-build-systems to the devops configuration for periodic update pull requests, see runtimeverification/devops#242. I also fixed the broken nix develop shell and refactored the dependencies of both the nix develop shell and kevm derivation. While doing so, I noticed that the derivation is built with g++. I think that clang might be preferred here for performance reasons. In fact, clang was/is included in the dependencies of the derivation, but not used. To switch out the compiler that is used by default, you typically swap out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tothtamas28 Please review the nix part and workflows that I worked on. I can't request a review from you as you are the PR owner. |
0299e42
to
95eb858
Compare
Dismissing to avoid merging before an approval from Palina or Andrei.
``` | ||
|
||
To enable the debug symbols for the llvm backend, build using this command: | ||
|
||
```sh | ||
poetry -C kevm-pyk run kdist build evm-semantics.llvm --arg enable-llvm-debug=true | ||
uv --project kevm-pyk run -- kdist build evm-semantics.llvm --arg enable-llvm-debug=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit off-topic, but I wasn't aware of the --project
. Until now, I've been using uv run --directory $PATH
to run a project when building from source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
bdd3942
into
master
No description provided.